Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #24 - CourseDrawingVC UI 구현 #25

Merged
merged 15 commits into from
Jan 3, 2023
Merged

[Feat] #24 - CourseDrawingVC UI 구현 #25

merged 15 commits into from
Jan 3, 2023

Conversation

lsj8706
Copy link
Collaborator

@lsj8706 lsj8706 commented Jan 3, 2023

🌱 작업한 내용

  • CourseDrawingVC UI 구현
  • 이를 위해 RNMapView (커스텀한 네이버 지도) 수정

🌱 PR Point

  • 핵심 뷰인 지도 그리기 뷰를 구현했습니다.
  • 화면 전환이 살짝 밋밋해서 애니메이션을 추가했습니다. (디자인 쪽에서 별로라고 하면 제거 예정)

📸 스크린샷

구현 내용 스크린샷
지도 그리기 뷰 Simulator Screen Recording - iPhone 14 - 2023-01-03 at 21 23 54

📮 관련 이슈

lsj8706 added 13 commits January 3, 2023 16:29
@lsj8706
[Feat] Runnect#24 - 지도 로직 수정
c984f4a
@lsj8706
[Feat] Runnect#24 - CustomNavigationBar에 메소드 추가
9558d09
@lsj8706
[Feat] Runnect#24 - DepartureSearchVC 기초 UI 구현
f1fd908
@lsj8706
[Feat] Runnect#21- 출발지 설정하기 버튼 클릭 시 애니메이션 구현
62bbaa8
@lsj8706
[Feat] Runnect#21 - 화면 전환 시 네비바 추가
8a5fa14
@lsj8706
[Feat] Runnect#24 - mapView의 unDo 버튼 생성
74c69ea
@lsj8706
[Feat] Runnect#24 - 화면 전환 시 네비바 추가
482953e
@lsj8706
[Feat] Runnect#24 - mapView의 unDo 버튼 생성
6f25091
@lsj8706
[Feat] Runnect#24 - mapView Binding
fae365c
@lsj8706
Merge remote-tracking branch 'origin/feat/Runnect#24-CourseDrawingVC-…
4a79bbd 
…UI' into feat/Runnect#24-CourseDrawingVC-UI
@lsj8706
[Fix] Runnect#24 - 지도 레이아웃 오류 해결
cdc1632
@lsj8706
[Feat] Runnect#24 - marker가 2개 이상일 때 완성하기 버튼 enabled 처리
9b46cb7
@lsj8706
[Feat] Runnect#24 - undoButton의 위치를 RNMapView에서 VC로 이동
a34536f
@lsj8706 lsj8706 added Feat 새로운 기능 구현 세진☃️ labels Jan 3, 2023
@lsj8706 lsj8706 self-assigned this Jan 3, 2023
dlwogus0128
dlwogus0128 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉! 어렵네욥..ㅋ 리드 짱~~

@lsj8706 lsj8706 merged commit 7f53089 into Runnect:develop Jan 3, 2023
@lsj8706 lsj8706 deleted the feat/#24-CourseDrawingVC-UI branch January 3, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwogus0128 dlwogus0128 dlwogus0128 approved these changes

@lee-yeonwoo lee-yeonwoo Awaiting requested review from lee-yeonwoo

Assignees

@lsj8706 lsj8706

Labels
Feat 새로운 기능 구현 세진☃️
Projects
Runnect-iOS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] CourseDrawingVC UI 구현
2 participants
@lsj8706 @dlwogus0128