[Fix] #250 - 파이어베이스 공용계정으로 이전 하였습니다. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingineeer
force-pushed
the
#260-setting
branch
from
952b770 to
e758433
Compare
513sojin
approved these changes
Feb 3, 2024
Comment on lines
+11
to
25
| struct KakaoAddressSearchingResponseDto: Codable { /// 사용 안함 | ||
| let meta: Meta | ||
| let documents: [Document] | ||
|
|
||
| func toDepartureLocationModel(latitude: Double, longitude: Double) -> DepartureLocationModel { | ||
| let roadName = self.documents[0].roadAddress.buildingName ?? "내가 설정한 출발지" | ||
| let roadName = self.documents[0].roadAddress.buildingName | ||
|
|
||
| return DepartureLocationModel(departureName: roadName, departureAddress: self.documents[0].address.addressName, latitude: String(latitude), longitude: String(longitude)) | ||
| return DepartureLocationModel( | ||
| departureName: roadName, | ||
| departureAddress: self.documents[0].address.addressName, | ||
| latitude: String(latitude), | ||
| longitude: String(longitude) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
카카오 주소 검색 api 나중에 혹~시라도 활용할까봐 남겨뒀는데
사용하지 않을 것 같아서 관련 issue(191번)에서 작업하고 다시 언급드리겠습니당 ~ 이런거 하나까지 꼼꼼하게 봐주셔서 감사합니다 🙇🏻♀️
| @@ -185,11 +185,13 @@ extension CourseDetailVC { | |||
| let description = publicCourse.description | |||
| let courseImage = publicCourse.image | |||
|
|
|||
| let dynamicLinksDomainURIPrefix = "https://runnect.page.link" | |||
| let dynamicLinksDomainURIPrefix = "https://rnnt.page.link" | |||
There was a problem hiding this comment.
pr 작업한 내용에 언급해주신거 확인했습니다 ~
| @@ -211,7 +211,7 @@ extension MarathonMapCollectionViewCell { | |||
| LoadingIndicator.hideLoading() | |||
| } | |||
|
|
|||
| guard let self = self else { return } | |||
| guard self != nil else { return } | |||
There was a problem hiding this comment.
이 코드는 옵셔널 바인딩이 아니라 nil인지 아닌지를 확인하는 코드인건가요 ?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
파이어 베이스 계정 이전으로 인한, URL 수정
applinks:rnnt.page.link링크로 바꿧는데, 기존applinks:runnect.page.link 링크(명진계정)삭제 후우남계정에 만드려고 했으나도메인이 한달정도 뒤에 지워진다해서 어쩔수 없이
applinks:rnnt.page.link요렇게 바꿨습니다.fastlane match파일 생성
이 부분은 private 레포의 브랜치 파서 (러넥트앱, 그 밖의 다른앱) 따로따로 인증서 관리를 위함 입니다.
📮 관련 이슈