Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #39 - CourseDiscoveryVC UI 수정 #39

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

lee-yeonwoo
Copy link
Collaborator

🌱 작업한 내용

  • mapCollectionView 구현
  • courseDiscoveryVC UI 구현

🌱 PR Point

  • PR Point 1

📸 스크린샷

Simulator Screen Recording - iPhone 14 - 2023-01-03 at 19 11 55

📮 관련 이슈

@lee-yeonwoo lee-yeonwoo changed the title [fix] #38 courseDiscoveryVC UI 수정 [fix] #39 courseDiscoveryVC UI 수정 Jan 5, 2023
@lsj8706 lsj8706 changed the title [fix] #39 courseDiscoveryVC UI 수정 [Fix] #39 - CourseDiscoveryVC UI 수정 Jan 5, 2023
@lsj8706 lsj8706 requested a review from dlwogus0128 January 5, 2023 06:01
@lee-yeonwoo lee-yeonwoo requested a review from lsj8706 January 5, 2023 06:01
Copy link
Collaborator

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!!

private func layout() {
view.backgroundColor = .w1
containerView.backgroundColor = .clear
// mapCollectionView.backgroundColor = .systemGray4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안쓰는 코드는 지워주세요~!

$0.top.equalTo(self.titleView.snp.bottom).offset(10)
$0.leading.trailing.equalTo(view.safeAreaLayoutGuide)
$0.bottom.equalToSuperview()
$0.height.equalTo(1000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top과 bottom 이 이미 잡혀있어서 height는 안줘도 됩니다~!

@lee-yeonwoo lee-yeonwoo merged commit 2e158fa into Runnect:develop Jan 5, 2023
lee-yeonwoo pushed a commit to lee-yeonwoo/Runnect-iOS that referenced this pull request Jan 5, 2023
lee-yeonwoo pushed a commit to lee-yeonwoo/Runnect-iOS that referenced this pull request Jan 5, 2023
@lee-yeonwoo lee-yeonwoo deleted the #3-DiscoveryVC구현 branch January 5, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Fix] courseDiscoveryVC 구현
3 participants