Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #33 - RunningRecordVC UI #42

Merged
merged 13 commits into from
Jan 5, 2023
Merged

[Feat] #33 - RunningRecordVC UI #42

merged 13 commits into from
Jan 5, 2023

Conversation

lsj8706
Copy link
Collaborator

@lsj8706 lsj8706 commented Jan 5, 2023

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ๋‹ฌ๋ฆฌ๊ณ  ๋‚œ ํ›„ ๊ธฐ๋ก ๋ทฐ ์ธ RunningRecordVC UI๋ฅผ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋Œœ.

๐ŸŒฑ PR Point

  • ์ค‘๋ณต๋˜๋Š” ๋ทฐ๊ฐ€ ๋งŽ์•„์„œ ๋”ฐ๋กœ class๋กœ ๋นผ์„œ ๊ตฌํ˜„ํ•œ ๊ฒƒ๋“ค์ด ์žˆ์Šต๋‹ˆ๋‹ค. UIComponents ํด๋”๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”
  • ํ™”๋ฉด ํ„ฐ์น˜ ์‹œ ํ‚ค๋ณด๋“œ ๋‚ด๋ฆฌ๊ธฐ์™€ ํ‚ค๋ณด๋“œ ๋“ฑ์žฅ์‹œ ํ…์ŠคํŠธ ํ•„๋“œ ์œ„์น˜ ์˜ฌ๋ฆฌ๊ธฐ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

๊ตฌํ˜„ ๋‚ด์šฉ ์Šคํฌ๋ฆฐ์ƒท
RunningRecordVC Simulator Screen Recording - iPhone 14 - 2023-01-05 at 16 05 24
๊ณตํ†ต UIComponent๋กœ ๋ถ„๋ฆฌํ•œ ๋ถ€๋ถ„ image

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

lsj8706 added 13 commits January 5, 2023 00:47
@lsj8706
[Feat] Runnect#33 - RunningRecordVC ๊ธฐ์ดˆ UI ๊ตฌํ˜„
90e602d
@lsj8706
[Feat] Runnect#30 - ๋Ÿฌ๋‹ ๊ธฐ๋ก์„ ์œ„ํ•œ ๋ฉ”์†Œ๋“œ ์ถ”๊ฐ€
3dad36f
@lsj8706
[Feat] Runnect#33 - RNTimeFormatter ์ถ”๊ฐ€
468e2ac
@lsj8706
[Feat] Runnect#33 - RunningRecordVC ๋ฐ์ดํ„ฐ ๋ฐ”์ธ๋”ฉ
2eb91eb
@lsj8706
[Chore] Runnect#33 - stopwatch ์ž‘๋™ ์‹œ์ ์„ viewWillAppear๋กœ ๋ณ€๊ฒฝ
ef4b25b
@lsj8706
[Feat] Runnect#33 - ์ฝ”์Šค ์ด๋ฏธ์ง€ ๋ฐ”์ธ๋”ฉ
fe2571d
@lsj8706
[Feat] Runnect#33 - ์ง€๋„ ์บก์ณ ๋กœ์ง ๊ฐœ์„ 
c1703bc
@lsj8706
[Feat] Runnect#33 - ๋”๋ฏธ ์ง€๋„ ์คŒ ๋ ˆ๋ฒจ ๋ณ€๊ฒฝ
a908591
@lsj8706
[Feat] Runnect#33 - ์ง€๋„ ์บก์ณ ์‹œ์  ๋ณ€๊ฒฝ
b208cfc
@lsj8706
[Feat] Runnect#33 - CourseDrawingVC์—์„œ ์ง€๋„ ์บก์ณ ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ •
551d1af
@lsj8706
[Chore] Runnect#33 - RunTrackingVC๋กœ ์บก์ณ ์ด๋ฏธ์ง€ ์ „๋‹ฌ
d0a3a66
@lsj8706
[Fix] Runnect#33 - ์žฌ์บก์ณํ•  ๋•Œ ๊ธฐ์กด์˜ ๋งˆ์ปค๊ฐ€ ์ง€์›Œ์ง€์ง€ ์•Š์•˜๋˜ ๋ฌธ์ œ ํ•ด๊ฒฐ
f717b6f
@lsj8706
[Merge] Runnect#33 - pull develop
d65fc62
@lsj8706 lsj8706 added Feat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์„ธ์ง„โ˜ƒ๏ธ labels Jan 5, 2023
@lsj8706 lsj8706 self-assigned this Jan 5, 2023
dlwogus0128
dlwogus0128 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปดํฌ๋„ŒํŠธ ์ž˜ ์“ฐ๋„๋ก ํ•˜๊ฒ ์‹ฌ๋” ใ…‹ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค

@lsj8706 lsj8706 merged commit 4d2a8a9 into Runnect:develop Jan 5, 2023
@lsj8706 lsj8706 deleted the feat/#33-RunningRecordVC-UI branch January 5, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwogus0128 dlwogus0128 dlwogus0128 approved these changes

@lee-yeonwoo lee-yeonwoo Awaiting requested review from lee-yeonwoo

Assignees

@lsj8706 lsj8706

Labels
Feat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์„ธ์ง„โ˜ƒ๏ธ
Projects
Runnect-iOS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ๋Ÿฌ๋‹ ๊ธฐ๋ก ๋ทฐ UI ๊ตฌํ˜„
2 participants
@lsj8706 @dlwogus0128