Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/duplicate tokens #63

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Feature/duplicate tokens #63

merged 3 commits into from
Jun 3, 2024

Conversation

izm20
Copy link

@izm20 izm20 commented May 27, 2024

We added duplicate token name detection to the token parser. If the parser detects a duplicate token name, we add a -duplicate suffix and log a warning to the console.

Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: f21ed5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@runroom/design-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 27, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
69.73% (-0.44% 🔻)
523/750
🔴 Branches
57.26% (-0.12% 🔻)
138/241
🟡 Functions
66.67% (-0.31% 🔻)
144/216
🟡 Lines
69.02% (-0.55% 🔻)
479/694
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / getTokens.ts
78.75% (-13.19% 🔻)
75% (-8.33% 🔻)
75% (-6.25% 🔻)
77.63% (-14.04% 🔻)

Test suite run success

85 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from f21ed5a

@izm20 izm20 merged commit a7f3ff3 into main Jun 3, 2024
3 checks passed
@izm20 izm20 deleted the feature/duplicate-tokens branch June 3, 2024 07:48
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant