Make appmetrics a global singleton #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure looks unrelated to my PR, a new Node v7 has been released (7.7.0) and appmetrics doesn't build on it. |
|
Looks like 7.7.0 build failure is due to nodejs/node#11628 |
sam-github
suggested changes
Mar 1, 2017
index.js
Outdated
| ); | ||
| module.exports = global.Appmetrics; | ||
| } else { | ||
| global.Appmetrics = this; |
There was a problem hiding this comment.
global.Appmetrics = module.exports; to avoid use of this as an alias for module.exports. Its true it does that, but its not documented, may stop working, and is confusing, because its not the typical usage of this.
sam-github
approved these changes
Mar 1, 2017
|
accepting as failing build is on the latest node7 which we don't officially support yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #402
@sam-github please review