Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GUI management #135

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

feat: GUI management #135

wants to merge 48 commits into from

Conversation

Distractic
Copy link
Collaborator

We need a GUI to open options, games, or something else.
To have better management of them through multi-thread and memory, we created some GUI:

  • PlayerGUI: Each player has a dedicated inventory loaded with his information (maybe stats, name, etc.)
  • LocaleGUI: Shared inventory dedicated to one language. If two players have the same language, they will share the same inventory
  • SingleGUI: Unique inventory shared with everyone

We added a way to animate inventory loading to avoid a "lag" sensation between the order to open the GUI and the load of data from IO operations.

Distractic and others added 23 commits December 14, 2023 14:52
@Distractic
feat(gui): Begin first implementation of guis
f94d77c
@Distractic
chore: Remove unused property
9431249
@Distractic
fix: Stack overflow when close gui
a960c11
@Distractic
fix: Add way to create inventory from scratch
c532cf8
@Distractic
fix: Use requireOpen function
0fc9c14
@Distractic
chore: Format
74cd704
@Distractic
fix: Change scope property
96d23fb
@Distractic
fix: Safe open by multiple check
85c1f89
@Distractic
test(gui-listener): Begin test about close GUI
8b0980d
@Distractic
chore: Return boolean when open GUI
e058f80
@Distractic
test: GUI on click
b42ba7c
@Distractic
test: Begin test for PersonalGUI close
b613270
@Distractic
fix(personal-gui): Create custom inventory for personal GUI
c8d302c
@Distractic
fix: Click on item when inventory open
2efa65c
@Distractic
test: Fix test about call suspending event
8cd1bab
@Distractic
test: Add test to trigger call event
e3890f1
@Distractic
test: Implement tests for Personal GUI
a93e84e
@Distractic
fix: Use mutex to avoid async issue
7301933
@Distractic
chore: Remove import
0237770
@Distractic
test: Open GUI for Personal GUI
a47a1dc
@Distractic
feat: Dedicate GUI for player or language
5368455
@Distractic
chore: Rename classes
ef66b2c
@Distractic
feat: Loading GUI (#134)
0bc8fd1
@Distractic Distractic added the enhancement New feature or request label Dec 19, 2023
@Distractic Distractic self-assigned this Dec 19, 2023
@Distractic
Copy link
Collaborator Author

I want to add a way to update the inventory of one client

@Distractic Distractic marked this pull request as ready for review December 20, 2023 13:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentixx Quentixx Awaiting requested review from Quentixx

At least 1 approving review is required to merge this pull request.

Assignees

@Distractic Distractic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Distractic @cizetux