-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Paper migration #49
Conversation
Maybe we can make some parts with minestom and some other parts with paper and like both with a proxy (velocity for instance) because minestom is much cheaper when it comes to hosting as it requires less performance |
It's an interesting idea but it requires redesigning the API to handle PaperMC and Minestom. It should be clarified in which use cases Minestom is preferable:
I haven't thought of all cases, tell me what do you think @bananasmoothii |
Yes, that is probably a good way. The connection between servers could be made via redis |
Having two types of server (Minestom and Spigot) is a real challenge and requires a lot of work. Because when you have to implement a feature on one, you will probably have to implement it on the other. This will require having two APIs to maintain. Concerning the communication between the servers, whatever the type, the servers will be able to communicate between them using the proxy and to send messages to each other using redis |
In conclusion, we will therefore stick to our choice to migrate to full PaperMC, to avoid a substantial workload. To our keyboards! |
Deleting old code before import working code for paper.
Deleting old tests before import working code for paper
…e/paper-migration
Co-authored-by: Cizetux <cizetux@gmail.com>
SonarCloud Quality Gate failed. 0 Bugs 61.3% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Context
The Minestom library ultimately does not meet our needs from a maintainability point of view.
After some consideration, @Distractic, @bananasmoothii and I agreed to migrate the library to PaperMC which is a fork of the Spigot project.
Benefits
Disadvantages compared to Minestom
Objective of the PR