Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method of binding an ErrorCode to parser errors #2385

Closed
philberty opened this issue Jul 6, 2023 · 1 comment · Fixed by #2542
Closed

Add method of binding an ErrorCode to parser errors #2385

philberty opened this issue Jul 6, 2023 · 1 comment · Fixed by #2542
Labels
diagnostic diagnostic static analysis
Milestone
GCC 14 Stage 3

Comments

@philberty
Copy link
Member

we use an Error struct in rust-diagnostics.h

gccrs/gcc/rust/rust-diagnostics.h

Line 133 in 5406b63

struct Error

This does not have the ability to store an Error code or Rich location so we cannot emit error codes for parser errors or expansion errors
@philberty philberty added the diagnostic diagnostic static analysis label Jul 6, 2023
@philberty philberty added this to the GCC 14 Stage 3 milestone Jul 6, 2023
@philberty
Copy link
Member Author

@MahadMuhammad ^^

This was referenced Aug 9, 2023
Merged
Merged
MahadMuhammad added a commit to MahadMuhammad/gccrs that referenced this issue Aug 10, 2023
@MahadMuhammad
gccrs: Support for rich-loc & errorcode in parser error
c4f5e5f 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
@MahadMuhammad MahadMuhammad mentioned this issue Aug 10, 2023
Merged
MahadMuhammad added a commit to MahadMuhammad/gccrs that referenced this issue Aug 10, 2023
@MahadMuhammad
gccrs: Support for rich-loc & errorcode in parser error
d08152e 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad added a commit to MahadMuhammad/gccrs that referenced this issue Aug 11, 2023
@MahadMuhammad
gccrs: Support for rich-loc & errorcode in parser error
b1eee3f 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad added a commit to MahadMuhammad/gccrs that referenced this issue Aug 11, 2023
@MahadMuhammad
gccrs: Support for rich-loc & errorcode in parser error
1338a41 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue Aug 16, 2023
@MahadMuhammad @philberty
gccrs: Support for rich-loc & errorcode in parser error
efa3041 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes #2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
@MahadMuhammad MahadMuhammad moved this from In Progress to Done Supported Error Codes in Error Code Support & Improving User Errors Aug 18, 2023
@MahadMuhammad MahadMuhammad mentioned this issue Aug 26, 2023
Open
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Nov 15, 2023
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
a4e624f 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Nov 21, 2023
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
33cad51 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Nov 21, 2023
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
87ccb41 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 5, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
61ff913 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 8, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
10ac4fd 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
62280fc 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
b425f55 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
b003976 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
ee3be06 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
9148f27 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
271759d 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
c79b3b9 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 9, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
34b84f6 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 11, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
786281d 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 12, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
c3829e5 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 16, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
7b766d9 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur pushed a commit to CohenArthur/gccrs that referenced this issue Jan 16, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
d689dd6 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
nstester pushed a commit to nstester/gcc that referenced this issue Jan 16, 2024
@MahadMuhammad @CohenArthur
gccrs: Support for rich-loc & errorcode in parser error
4ad44ea 
Added method of binding ErrorCode & rich location to
parser and expansion errors.
Fixes Rust-GCC/gccrs#2385

gcc/rust/ChangeLog:

	* rust-diagnostics.cc (va_constructor):
	Added constructor for all possible cases.
	(Error::Error): Updated error struct
	for all possible cases.
	* rust-diagnostics.h (struct Error):
	Updated error struct to support error
	code & rich location support.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostic diagnostic static analysis
Projects
None yet
Milestone
GCC 14 Stage 3
Development

Successfully merging a pull request may close this issue.

Support for rich-loc & errorcode in parser & expansion errors MahadMuhammad/gccrs
1 participant
@philberty