Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin node16 by allowing old version #3081

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Pin node16 by allowing old version #3081

merged 1 commit into from
Jul 10, 2024

Conversation

badumbatish
Copy link
Contributor

@badumbatish badumbatish commented Jul 10, 2024 •
edited

Issues being reported and fixes are here.
actions/checkout#1487
actions/checkout#1809

@badumbatish
Pin node16 by allowing old version
f64bfd4 
ChangeLog:

	* .github/workflows/ccpp.yml:
	Pin node16 by allowing old version
@badumbatish badumbatish mentioned this pull request Jul 10, 2024
Merged
@P-E-P P-E-P requested review from P-E-P and CohenArthur July 10, 2024 09:23
P-E-P
P-E-P approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look to both linked issues and this is probably our only way forward until an update is rolled out.

@CohenArthur
Copy link
Member

interesting to note: actions/checkout#1809 (comment)

something we get to revisit in a few months I guess :D

@CohenArthur CohenArthur added this pull request to the merge queue Jul 10, 2024
Merged via the queue into Rust-GCC:master with commit fde617a Jul 10, 2024
9 checks passed
@badumbatish badumbatish deleted the libgc_226_fix branch July 11, 2024 22:14
@narrieta narrieta mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badumbatish @CohenArthur @P-E-P