Friendlier ControllerDeviceAdded and JoyDeviceAdded which values
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticky
force-pushed
the
friendlier-controllerdeviceadded
branch
from
1560cc4 to
b1dc2ad
Compare
|
This is missing an update to |
|
I’ve added the HapticSubsystem update, and updated its example code to match. |
|
Thanks for your contribution and sorry for the delay! |
|
No worries. Thanks for accepting it! 😃 |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
…ceadded Friendlier ControllerDeviceAdded and JoyDeviceAdded `which` values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
whichproperties ofControllerDeviceAddedandJoyDeviceAddedevents to beu32s, as described in #713. This makes their types match the methods for opening controllers and joysticks.It also adds documentation to differentiate between the now differing types of
whichvalues Controller and Joystick events contain, and updates the parameter names of joystick and controller methods to be more consistent about differentiating “joystick IDs” and “joystick indexes”.fixes #713