Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience functions #988

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

No description provided.

@Cobrand
Copy link
Member

Cobrand commented Apr 25, 2020

Weird, travis isn't working?

It doesn't compile with the unsafe_textures feature, to be expected, because with that feature Texture doesn't have a lifetime. The solution is unfortunately to create 2 versions: one with the lifetime and one without, with the one without being feature-gated behind unsafe_textures.

@GuillaumeGomez
Copy link
Contributor Author

Weird for no travis run... I'll update my PR meanwhile.

@GuillaumeGomez
Copy link
Contributor Author

Updated (and still no travis?).

@Cobrand
Copy link
Member

Cobrand commented Apr 25, 2020

https://travis-ci.org/github/Rust-SDL2/rust-sdl2/builds/679429402 The travis build worked, but for some reason it's not displayed here.

Thanks!

@Cobrand Cobrand merged commit 3c6e104 into Rust-SDL2:master Apr 25, 2020
@GuillaumeGomez GuillaumeGomez deleted the convenience branch April 25, 2020 16:20
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants