Globally deny Clippy and rust_2018_idioms
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@wedsonaf This includes a small change to be Clippy warning free now that it applies globally, i.e. to kernel modules too. Also, there were a few cleanups required for |
ojeda
changed the title
rust_2018_idiomsrust_2018_idioms
|
The Clippy part was triggered thanks to @flip1995 that made me notice that rust-lang/rust-clippy#6799 was working. |
nbdd0121
reviewed
Jul 2, 2021
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This allows to remove the `#[deny(clippy::*)]` lines, and makes catching Clippy issues in the leaf modules. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.