Fix(484) - ChannelVolume misbehaving #493
Conversation
DivineGod
force-pushed
the
fix/channel-volume
branch
2 times, most recently
from
0f059bd
to
50b6f40
Compare
move channel from fix to constructor, add test Empty Source should not have a sample rate. Sample Rate Conversion to handle Empty source properly add more doc around Empty
DivineGod
force-pushed
the
fix/channel-volume
branch
from
50b6f40
to
1167092
Compare
There was a problem hiding this comment.
First thanks a lot for going after this issue. Does the example your PR adds reproduce the issue? I would love to have a test that reproduces it.
If I understand correctly your approach modifies the channel converter and sample rate converter to recognize the Empty source. They do so by checking for its now nonsensical channel count and sample rate of zero.
An alternative would be removing the use of empty in queue (used by Sink::try_new) here:
Line 110 in a904566
We could use a Option<()> there and make the None branch play 'empty' sounds.
On the other hand, Empty probably has other valid uses....
Quite a difficult one this. I do not have any more time right now, ill come back to this.
src/source/empty.rs
Outdated
| @@ -36,17 +39,17 @@ where | |||
| { | |||
| #[inline] | |||
| fn current_frame_len(&self) -> Option<usize> { | |||
| None | |||
| Some(0) | |||
There was a problem hiding this comment.
I am not sure about this change. None means the frame length will not change going forward. I do not know what Some(0) means. Filters/wrappers around the Empty source will treat every new sample as a new frame and run code paths to handle that.
There was a problem hiding this comment.
I don't recall why I had that in there. I don't think it needs to be there. So I'll happily revert that change
Yes, it does, running the example on |
Nice, then I can try it out and play around a little with the PR |
|
I do not yet understand why I can not merge this until I understand everything around it. Unfortunately I do not have a lot of time allocated for this, so it could a bit. I'll keep you updated. |
|
That’s totally understandable. I am happy to help out getting it to a state where it fixes things and there’s an understanding of why it all works out |
This PR will probably collect a few fixes that relate to #484 as I go through
rodioto find all the issues that seem to prevent proper use ofChannelVolume.I think I've identified a few areas that need attention, first being the
ChannelCountConverterwhich is started with anEmptysource whenSink::try_newis called. This would cause an issue where the channel converter had the wrongtocount, as the actual source input channel count might not necessarily be 1 as the empty source was specifying. By settingEmptychannels to 0 and handling the cases where they show up, we can more gracefully handle these issues.Next issue is an issue with the sample rate converter where if there's a mismatch the
ChannelVolumeonce again seem to be messed up and not produce the right results. This might also have been identified in other issues; I've not triaged them all yet.