Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional metadata support #136

Merged
merged 13 commits into from
Mar 6, 2021
Merged

optional metadata support #136

merged 13 commits into from
Mar 6, 2021

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Jan 10, 2021

Mostly behind a feature flag since it isn't supported until 1.9.13.

Not all of the property methods actually require a client but it felt more ergonomic to have them be consistent and make them methods on a client.

x37v added 10 commits January 10, 2021 07:57
@x37v
added UUID bindings to jack-sys
2f4e8a6 
bindgen uuid.h -o uuid.rs --whitelist-function jack_uuid.* --whitelist-type jack_uuid.*
@x37v
advance the jack-sys version
f5069a1
@x37v
add client uuid methods and tests
3900487
@x37v
adding property get/set/remove
e9f9b69 
TODO callback
@x37v
add property change handler and tests
e174da8
@x37v
type-o fix
0bb8c8b
@x37v
ergonomics update, methods on client
221f9e3 
some of the methods don't actually require a client but it feels more
ergonomic to simply make them all consistent.
@x37v
feature gate the metadata support
016123b 
it doesn't exist until 1.9.13
@x37v
update ffi completeness doc
e0525b9
@x37v
document version string
765b03a
@x37v x37v mentioned this pull request Jan 10, 2021
Open
@x37v
Copy link
Contributor Author

x37v commented Jan 11, 2021

the action uses libjack0
i assume most folks are using jack2 these days but maybe not?
I guess I could feature flag the jack_get_version_string call too..

@x37v
Copy link
Contributor Author

x37v commented Jan 11, 2021

the action uses libjack0
i assume most folks are using jack2 these days but maybe not?
I guess I could feature flag the jack_get_version_string call too..

Actually, it looks like jack_get_version_string doesn't exist in the shared headers that I have on my system either.
Unfortunately it doesn't look like the author of jack-sys included the commands they used to create the bindings. It would be really nice to include that.

@x37v
Copy link
Contributor Author

x37v commented Mar 4, 2021

wondering if anyone has any thoughts on this PR.. maybe @wmedrano ?

@wmedrano
Copy link
Member

wmedrano commented Mar 6, 2021

lgtm and tests are passing.

Is this good to merge? If so, I can make a new release as version 0.6.6 immediately after.

@x37v
Copy link
Contributor Author

x37v commented Mar 6, 2021

lgtm and tests are passing.

Is this good to merge? If so, I can make a new release as version 0.6.6 immediately after.

I think its good to merge. A good portion of this is behind a feature gate so its an opt in sort of thing, but yeah, I think its worth having.

@wmedrano wmedrano merged commit 7f99add into RustAudio:main Mar 6, 2021
@wmedrano
Copy link
Member

wmedrano commented Mar 6, 2021

Done, this should be live in version 0.6.6.

@PieterPenninckx PieterPenninckx mentioned this pull request Apr 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x37v @wmedrano