ocb3: use dbl crate
#606
Merged
ocb3: use dbl crate
#606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the vendored implementation of GF(2^128) doubling (i.e. multiply-by-x) with the `dbl` crate. Also moves the remaining functions in the `util` module into lib.rs.
|
IIRC you argued that we should deprecate the |
|
Hmm, tough call. On the one hand it is a pattern that appears in a lot of places, although right now the polynomial is hardcoded. On the other we don't provide optimized implementations so the implementation is trivial. |
|
I think we should go ahead and merge this, and if we decide to retire |
|
I made a tracking issue about potentially retiring In the meantime I think we should move forward with this, and rip it out if we decide to rip it out everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the vendored implementation of GF(2^128) doubling (i.e. multiply-by-x) with the
dblcrate.Also moves the remaining functions in the
utilmodule into lib.rs.