Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benches: fix compilation errors #645

Merged
merged 1 commit into from
Oct 28, 2024
Merged

benches: fix compilation errors #645

merged 1 commit into from
Oct 28, 2024

Conversation

newpavlov
Copy link
Member

Also fix benches CI job and tweak ascon-aead benchmarks to make them more consistent with other benchmarks.

Closes #549

@newpavlov newpavlov merged commit 1da7daf into master Oct 28, 2024
4 checks passed
@newpavlov newpavlov deleted the bench_fix branch October 28, 2024 12:46
@tarcieri
Copy link
Member

Hmm, benches.yml should probably run whenever any of the relevant crates are changed, or we should factor it into the individual crate-related .yml files and only run focused benchmarks for the one(s) that is/are changed.

It seems like because we don't have something like that, these breakages weren't spotted along with the breaking changes.

@newpavlov
Copy link
Member Author

I agree that we should run it on changes in the relevant crates, but it's not the reason why the breakage was not caught. It was because cargo build --release does not build benches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using cycles for ascon-aead instead of milliseconds
2 participants