fix HKDF-Extract with empty salt #45 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Dec 8, 2020
newpavlov
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Thank you! I have improved your fix with a slightly more elegant solution.
Could you also please add a test vector for an empty salt from the RFC, so we will not get a regression in future? If you don't have time right now, no worries, I can add it in a separate PR a bit alter.
@tarcieri
Maybe it's worth to add a RUSTSEC advisory for this bug?
|
i think do not need add a RUSTSEC advisory for this "bug". Because this "bug" will only appear when See code: |
Ah, yes. You are correct. :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45 .