Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a md5 implementation using inline assembly instead of relying on
cc
and.S
. This has the benefit of compiling and running on MSVC targets.Correctness
I have run a custom version of
md-5
pointing to this branch withcargo +nightly test --features asm
andcargo +nightly test --features asm --target i686-pc-windows-msvc
on a windows machine and passed the test.Performance
On my Linux machine, which has a Intel 6700K
Before:
After:
No observable performance degradation.
Drawback
This change needs a MSRV bump to
1.59.0
where inline assembly was stabilized.