Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belt-Wblock implementation #362

Merged
merged 20 commits into from
Apr 15, 2023
Merged

Belt-Wblock implementation #362

merged 20 commits into from
Apr 15, 2023

Conversation

makavity
Copy link
Contributor

Implemented wblock_enc and wblock_dec inherit functions in BeltBlock struct.

@makavity makavity mentioned this pull request Apr 13, 2023
Closed
newpavlov
newpavlov reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to think a bit about making the methods more idiomatic, but for now I have the following comments.

.github/workflows/belt-block.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
belt-block/Cargo.toml Outdated Show resolved Hide resolved
belt-block/src/cipher_impl.rs Outdated Show resolved Hide resolved
belt-block/CHANGELOG.md Outdated Show resolved Hide resolved
belt-block/src/cipher_impl.rs Outdated Show resolved Hide resolved
belt-block/src/cipher_impl.rs Outdated Show resolved Hide resolved
newpavlov
newpavlov reviewed Apr 13, 2023
View reviewed changes
belt-block/tests/mod.rs Outdated Show resolved Hide resolved
@newpavlov newpavlov merged commit b875dba into RustCrypto:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makavity @newpavlov