Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k256: add keccak256 feature #142

Merged
merged 1 commit into from
Aug 26, 2020
Merged

k256: add keccak256 feature #142

merged 1 commit into from
Aug 26, 2020

Conversation

tarcieri
Copy link
Member

Ethereum-style signatures (k256::ecdsa::recoverable::Signature) use Keccak256.

This commit adds a keccak256 feature which can be used to compute these signatures using Keccak256 automatically.

Ethereum-style signatures (`k256::ecdsa::recoverable::Signature`) use
Keccak256.

This commit adds a `keccak256` feature which can be used to compute
these signatures using Keccak256 automatically.
@codecov-commenter
Copy link

Codecov Report

Merging #142 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   50.77%   50.70%   -0.08%     
==========================================
  Files          21       21              
  Lines        3490     3491       +1     
==========================================
- Hits         1772     1770       -2     
- Misses       1718     1721       +3     
Impacted Files Coverage Δ
k256/src/ecdsa/recoverable.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/signer.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/scalar/scalar_4x64.rs 75.45% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572ccbb...06fe85a. Read the comment docs.

@tarcieri tarcieri merged commit dd701d0 into master Aug 26, 2020
@tarcieri tarcieri deleted the k256/ecdsa-keccak256 branch August 26, 2020 00:16
@tarcieri tarcieri mentioned this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants