Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k256: use NonZeroScalar for ECDSA signature components #144

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

tarcieri
Copy link
Member

Simplifies checks that r and s are non-zero by using the NonZeroScalar type.

Simplifies checks that `r` and `s` are non-zero by using the
`NonZeroScalar` type.
@codecov-commenter
Copy link

Codecov Report

Merging #144 into master will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   50.75%   50.81%   +0.05%     
==========================================
  Files          21       21              
  Lines        3491     3487       -4     
==========================================
  Hits         1772     1772              
+ Misses       1719     1715       -4     
Impacted Files Coverage Δ
k256/src/ecdsa/recoverable.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/verifier.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8206097...d6c732b. Read the comment docs.

@tarcieri tarcieri merged commit 492996e into master Aug 26, 2020
@tarcieri tarcieri deleted the k256/use-non-zero-scalar-for-ecdsa-components branch August 26, 2020 20:08
@tarcieri tarcieri mentioned this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants