Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ecdsa::{Signer, Verifier} => {SigningKey, VerifyKey} #153

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Sep 2, 2020

@codecov-commenter
Copy link

Codecov Report

Merging #153 into master will decrease coverage by 0.06%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   60.28%   60.21%   -0.07%     
==========================================
  Files          21       21              
  Lines        3555     3559       +4     
==========================================
  Hits         2143     2143              
- Misses       1412     1416       +4     
Impacted Files Coverage Δ
k256/src/ecdsa.rs 85.71% <ø> (ø)
k256/src/ecdsa/recoverable.rs 68.29% <ø> (ø)
k256/src/ecdsa/sign.rs 32.60% <0.00%> (ø)
k256/src/ecdsa/verify.rs 48.27% <0.00%> (ø)
p256/src/ecdsa.rs 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dcfb9f...5d3b635. Read the comment docs.

@tarcieri tarcieri merged commit 8f50b1a into master Sep 2, 2020
@tarcieri tarcieri deleted the ecdsa-signing-and-verify-keys branch September 2, 2020 18:25
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants