k256: gate ecdsa::{Signer, Verifier} impls on sha256 feature
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 58.53% 58.53%
=======================================
Files 25 25
Lines 3765 3765
=======================================
Hits 2204 2204
Misses 1561 1561
Continue to review full report at Codecov.
|
tarcieri
force-pushed
the
k256/gate-signer-verifier-impls-on-sha256
branch
from
4782ade to
f3caab3
Compare
They don't work otherwise. This isn't a SemVer breaking change, because they still didn't work without the feature enabled. This change provides a slightly better error message.
tarcieri
force-pushed
the
k256/gate-signer-verifier-impls-on-sha256
branch
from
f3caab3 to
ff4ff95
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't work otherwise.
This isn't a SemVer breaking change, because they still didn't work without the feature enabled. This change provides a slightly better error message.