k256: recoverable::Signature::recover_verify_key_from_digest_bytes #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `recover_verify_key_from_digest_bytes` method which operates on a byte array that's allegedy the digest of the message used to produce a given signature. Where `*Verifier` methods carry the risk of a signature forgery if they operate on something that's not a message digest (since this violates ROM under which ECDSA derives its security), there isn't a similar risk for public key recovery: the best an attacker can do is force recovery of a bogus key, and all recovered public keys are inherently untrusted until they can be validated against a key fingerprint. So this method doesn't have similar misuse concerns as signature verification.
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 58.70% 58.67% -0.04%
==========================================
Files 25 25
Lines 3775 3777 +2
==========================================
Hits 2216 2216
- Misses 1559 1561 +2
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
recover_verify_key_from_digest_bytesmethod which operates on a byte array that's allegedy the digest of the message used to produce a given signature.Where
*Verifiermethods carry the risk of a signature forgery if they operate on something that's not a message digest (since this violates ROM under which ECDSA derives its security), there isn't a similar risk for public key recovery: the best an attacker can do is force recovery of a bogus key, and all recovered public keys are inherently untrusted until they can be validated against a key fingerprint. So this method doesn't have similar misuse concerns as signature verification.