k256: remove non-endomorphism code #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was previously gated under the `endomorphism-mul` feature due to lingering concerns about the "GLV" patents, namely US7110538. According to @pwuille, a patent attorney he works with has verified that the patent is expired: https://twitter.com/pwuille/status/1310639051393830912 Likewise non-endomorphism code is being removed from `bitcoin-core/secp256k1`: bitcoin-core/secp256k1#826 This commit does the same for `k256`: it removes all the non-endomorphism code and feature gating from the endomorphism code, making the `endomorphism-mul` feature a no-op. We can remove the feature in the next SemVer-breaking release (v0.6.x)
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 58.49% 58.49%
=======================================
Files 25 25
Lines 3783 3783
=======================================
Hits 2213 2213
Misses 1570 1570
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was previously gated under the
endomorphism-mulfeature due to lingering concerns about the "GLV" patents, namely US7110538.According to @pwuille, a patent attorney he works with has verified that the patent is expired:
https://twitter.com/pwuille/status/1310639051393830912
Likewise non-endomorphism code is being removed from
bitcoin-core/secp256k1:bitcoin-core/secp256k1#826
This commit does the same for
k256: it removes all the non-endomorphism code and feature gating from the endomorphism code, making theendomorphism-mulfeature a no-op.We can remove the feature in the next SemVer-breaking release (v0.6.x).