k256+p256: make ecdsa a default feature
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
k256+p256/make-ecdsa-a-default-feature
branch
from
c42c3d1 to
5526add
Compare
We've gotten enough complaints from people who had trouble figuring out feature activations for `ecdsa` it's probably easier to just turn it on by default and let people who don't want it figure out how to shut it off if they so desire.
tarcieri
force-pushed
the
k256+p256/make-ecdsa-a-default-feature
branch
from
5526add to
42f1563
Compare
tarcieri
added a commit
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten enough questions/complaints from people who had trouble figuring out feature activations for
ecdsait's probably easier to just turn it on by default and let people who don't want it figure out how to shut it off if they so desire.