k256: fallible AffinePoint to VerifyingKey conversion
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarcieri
force-pushed
the
k256/fallible-affine-point-to-verifying-key-conversion
branch
from
9a78034 to
85a2c95
Compare
The inner type of `VerifyingKey` is a `PublicKey`, which is itself a wrapper for an inner curve-specific `AffinePoint` which ensures that the inner point is *NOT* the additive identity / point at infinity. Therefore, any conversion from an `AffinePoint` is potentially fallible, so the existing `From` conversions need to be changed to `TryFrom`. This commit also adds some additional type conversions between `AffinePoint`/`ProjectivePoint` and `PublicKey`/`VerifyingKey`, and also includes them in `p256` for consistency.
tarcieri
force-pushed
the
k256/fallible-affine-point-to-verifying-key-conversion
branch
from
85a2c95 to
a1699af
Compare
tarcieri
deleted the
k256/fallible-affine-point-to-verifying-key-conversion
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner type of
VerifyingKeyis aPublicKey, which is itself a wrapper for an inner curve-specificAffinePointwhich ensures that the inner point is NOT the additive identity / point at infinity.Therefore, any conversion from an
AffinePointis potentially fallible, so the existingFromconversions need to be changed toTryFrom.This commit also adds some additional type conversions between
AffinePoint/ProjectivePointandPublicKey/VerifyingKey, and also includes them inp256for consistency.