k256: Taproot Schnorr (BIP 340) #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Taproot-flavored Schnorr signatures as described in: https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki Work-In-Progress implementation: BROKEN, DO NOT USE
tarcieri
reviewed
May 19, 2022
k256/src/schnorr.rs
Outdated
Comment on lines
30
to
35
| // TODO(nickray): maybe store (FieldElement, NonScalar), avoiding the unwraps. | ||
| // However, this | ||
| // a) contradicts tarcieri's philosophy of storing "bag of bytes" | ||
| // b) makes the Debug, Eq, PartialEq, PartialOrd, Ord impls tricky, | ||
| // as FieldElement + NonZeroScalar don't implement them, so we'd have to | ||
| // either modify upstream or implement in terms of the calculated `to_bytes`. |
There was a problem hiding this comment.
I think it's fine to store the parsed components of the signature alongside bytes.
To simplify some of the questions you can remove the PartialOrd and Ord derives. I'm not sure they're useful for anything.
A handwritten Debug would probably make sense, either displaying the byte serialization or the parsed components of the signature.
tarcieri
reviewed
May 19, 2022
tarcieri
reviewed
May 19, 2022
|
Will go ahead and merge this. There are a few things I think can be addressed in a followup PR, most notably implementing the |
nickray
added a commit
to nickray/elliptic-curves
that referenced
this pull request
May 23, 2022
Implements Taproot-flavored Schnorr signatures as described in: https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki Co-authored-by: Tony Arcieri <bascule@gmail.com> Co-authored-by: Nicolas Stalder <nstalder@jumpcrypto.com>
This was referenced May 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Taproot-flavored Schnorr signatures as described in:
https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki
Based on #482, rebased onto master branch.