k256: rename precomputed-tables feature
#707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally introduced as `basepoint-tables` in #705
fjarri
reviewed
Jan 9, 2023
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features schnorr | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features serde | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features sha256 | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa,sha256 | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features basepoint-tables,bits,ecdh,ecdsa,hash2curve,jwk,pem,pkcs8,schnorr,serde,sha256 | ||
| - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features bits,ecdh,ecdsa,hash2curve,jwk,pem,pkcs8,precomputed-tables,schnorr,serde,sha256 |
There was a problem hiding this comment.
Btw, a pretty convenient tool to test crates with a lot of features: https://github.com/taiki-e/cargo-hack
There was a problem hiding this comment.
Yeah, we use it in a lot of other projects and even have an action to install a precomputed binary:
https://github.com/RustCrypto/actions/tree/master/cargo-hack-install
Haven't set it up here yet
fjarri
approved these changes
Jan 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally introduced as
basepoint-tablesin #705