k256: refactored lincomb to use LinearCombinationExt trait
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarcieri this code is working and looks good to me, only thing is whether we want to expose them as free functions or via a trait (I prefer the second) |
tarcieri
approved these changes
Nov 14, 2023
tarcieri
reviewed
Nov 15, 2023
tarcieri
reviewed
Nov 15, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
changed the title
lincomb into `lincomb_array and lincomb_slicelincomb to use LinearCombinationExt trait
tarcieri
reviewed
Nov 15, 2023
tarcieri
approved these changes
Nov 15, 2023
tarcieri
reviewed
Nov 15, 2023
# Conflicts: # Cargo.lock # Cargo.toml
|
Looks mergable to me |
|
Will merge when CI is green |
|
Great thanks @tarcieri now only the multiexp PR is left open on my side RustCrypto/crypto-bigint#248 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #973