k256+primeorder: add batch_normalize_generic
#975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Nov 15, 2023
tarcieri
force-pushed
the
k256/batch-normalize-generic
branch
3 times, most recently
from
e4f1c59 to
1f50f14
Compare
tarcieri
changed the title
batch_normalize_genericbatch_normalize_generic
tarcieri
force-pushed
the
k256/batch-normalize-generic
branch
from
1f50f14 to
95b9e28
Compare
Adds a generic implementation of `batch_normalize` which abstracts over backing storages.
tarcieri
force-pushed
the
k256/batch-normalize-generic
branch
from
95b9e28 to
613dc21
Compare
|
Yeah I see how our new trait design enables this. I've wanted something like this and am happy with your suggestion, so we ended up doing something better than originally intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic implementation of
batch_normalizewhich abstracts over backing storages.This is just implemented in
k256for now, but could potentially be further abstracted and extracted intoelliptic-curve.