Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsb: fix Reset impl and reduce crate size #300

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fsb: fix Reset impl and reduce crate size #300

merged 1 commit into from
Jul 21, 2021

Conversation

newpavlov
Copy link
Member

The previous Reset impl was not resetting bit_length.

Crate size reduced by using binary dump of PI which then used via include_bytes!. I haven't noticed that pi.rs was taking 1.7 MB. The binary dump now takes 268 KB.

Also tests are ported to macros from digest (they have helped to find the Reset bug).

cc @iquerejeta

@newpavlov newpavlov merged commit 1cb3dee into master Jul 21, 2021
@newpavlov newpavlov deleted the fsb_fix branch July 21, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newpavlov @tarcieri