ecdsa: bound curve implementations on Order trait #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 54.66% 54.66%
=======================================
Files 8 8
Lines 300 300
=======================================
Hits 164 164
Misses 136 136
Continue to review full report at Codecov.
|
The longer-term goal of this change is to eliminate the `CheckSignatureBytes` trait by having a generic implementation which uses the `Order::ORDER` constant. For now, just ensure that the curve's order is defined.
tarcieri
force-pushed
the
ecdsa/bound-curve-impls-on-order-trait
branch
from
4a233e5 to
ce550f4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The longer-term goal of this change is to eliminate the
CheckSignatureBytestrait by having a generic implementation which uses theOrder::ORDERconstant.For now, just ensure that the curve's order is defined.