Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: switch from ScalarBytes<C> to ScalarCore<C> #356

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Sep 3, 2021

Corresponding changes for RustCrypto/traits#732

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #356 (a1825a3) into master (969e9e7) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   53.65%   53.65%           
=======================================
  Files           9        9           
  Lines         328      328           
=======================================
  Hits          176      176           
  Misses        152      152           
Impacted Files Coverage Δ
ecdsa/src/sign.rs 0.00% <0.00%> (ø)
ecdsa/src/dev.rs 62.50% <100.00%> (ø)
ecdsa/src/lib.rs 37.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969e9e7...a1825a3. Read the comment docs.

@tarcieri tarcieri force-pushed the ecdsa/switch-from-scalarbytes-to-scalarcore branch from 110eb83 to a1825a3 Compare September 3, 2021 17:46
@tarcieri tarcieri merged commit 5961aaa into master Sep 3, 2021
@tarcieri tarcieri deleted the ecdsa/switch-from-scalarbytes-to-scalarcore branch September 3, 2021 19:39
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Sep 3, 2021
Corresponding changes for:

- RustCrypto/traits#732
- RustCrypto/signatures#356

This is an initial step towards having a generic `Scalar<C>` type which
is reusable over elliptic curves.

As part of these changes, `zeroize` was made a mandatory dependency.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Sep 3, 2021
Corresponding changes for:

- RustCrypto/traits#732
- RustCrypto/signatures#356

This is an initial step towards having a generic `Scalar<C>` type which
is reusable over elliptic curves.

As part of these changes, `zeroize` was made a mandatory dependency.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Sep 3, 2021
)

Corresponding changes for:

- RustCrypto/traits#732
- RustCrypto/signatures#356

This is an initial step towards having a generic `Scalar<C>` type which
is reusable over elliptic curves.

As part of these changes, `zeroize` was made a mandatory dependency.
@tarcieri tarcieri mentioned this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants