ecdsa: make Signature::normalize_s infallible
#780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unconditionally returns a normalized signature, regardless of whether the signature was normalized to begin with. Closes #736
tarcieri
force-pushed
the
ecdsa/infallible-normalization
branch
from
e2e70e8
to
e0870f7
Compare
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jan 17, 2024
It's now infallible and always returns a normalized signature regardless of if the original one was normalized or not: RustCrypto/signatures#780
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jan 17, 2024
It's now infallible and always returns a normalized signature regardless of if the original one was normalized or not: RustCrypto/signatures#780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unconditionally returns a normalized signature, regardless of whether the signature was normalized to begin with.
Closes #736