Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: remove SignPrimitive and VerifyPrimitive traits #793

Merged

Commits on Jan 18, 2024

  1. ecdsa: remove SignPrimitive and VerifyPrimitive traits

    The backstory of these traits was once upon a time we didn't yet have
    the trait structure in place to express algorithms like ECDSA signing
    and verification generically, so each crate (at the time just `k256` and
    `p256`) had a nearly duplicated implementation of ECDSA, with `k256`
    including tweaks for low-S normalization.
    
    Now the `ecdsa` crate contains fully generic implementations of both
    algorithms, and with the `EcdsaCurve` trait, carries a `NORMALIZE_S`
    preference, so these traits are just needless indirection at this point.
    
    This removes the traits, converting non-trivial methods into static
    functions in the `hazmat` module, namely `sign_prehashed_rfc6979`.
    tarcieri committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    0ab00f1 View commit details
    Browse the repository at this point in the history