chacha20: remove chacha20_force_neon cfg attribute
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables this functionality by default on `aarch64` targets, all of which have NEON by definition. The reason it was previously gated like this was because it required what was previously nightly-only functionality, however such functionality has since been stabilized.
newpavlov
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
You also need to edit the CI job accordingly.
https://github.com/RustCrypto/stream-ciphers/blob/master/.github/workflows/chacha20.yml#L192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables this functionality by default on
aarch64targets, all of which have NEON by definition.The reason it was previously gated like this was because it required what was previously nightly-only functionality, however such functionality has since been stabilized.