elliptic-curve: use sec1 crate's EncodedPoint
#771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/use-sec1-crate-encoded-point
branch
from
4b9b843 to
62bdd01
Compare
The `EncodedPoint` type was extracted to the `sec1` crate in: RustCrypto/formats#45 This switches the `elliptic-curve` to using the newly extracted implementation. This was a bit tricky/invasive as now `EncodedPoint` now only knows a size and not the rest of the details of the curve. APIs that were previously heavily leveraging `EncodedPoint` should probably switch to the `PublicKey` type instead unless they are specifically intending to work with SEC1-encoded points.
tarcieri
force-pushed
the
elliptic-curve/use-sec1-crate-encoded-point
branch
from
62bdd01 to
db13593
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 19, 2021
Incorporates upstream changes from: RustCrypto/traits#771
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 19, 2021
Incorporates upstream changes from: RustCrypto/traits#771
tarcieri
added a commit
that referenced
this pull request
Sep 20, 2021
This was removed in #771 but can still be supported
tarcieri
added a commit
that referenced
this pull request
Sep 20, 2021
) This was removed in #771 but can still be supported
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 20, 2021
These code changes are necessary to support a migration to the `sec1` crate, which extracted types like `EncodedPoint` into a separate reusable crate. Relevant `elliptic-curve` PR: RustCrypto/traits#771
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 20, 2021
These code changes are necessary to support a migration to the `sec1` crate, which extracted types like `EncodedPoint` into a separate reusable crate. Relevant `elliptic-curve` PR: RustCrypto/traits#771
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EncodedPointtype was extracted to thesec1crate in:RustCrypto/formats#45
This switches the
elliptic-curveto using the newly extracted implementation.This was a bit tricky/invasive as now
EncodedPointnow only knows a size and not the rest of the details of the curve.APIs that were previously heavily leveraging
EncodedPointshould probably switch to thePublicKeytype instead unless they are specifically intending to work with SEC1-encoded points.