-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uprev generic array to version 0.14 #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.14 they added a pretty nice feature, which is that you can now split not just arrays that you hold by value, but you can split references to generic arrays, into a pair of references to generic arrays corresponding to the subslices, where the size calculations are done correctly at compile-time and the buffer size information is all preserved. https://docs.rs/generic-array/0.14.1/src/generic_array/sequence.rs.html#302-320 I have some ECIES code that looks like this, that builds on `aead` trait: ``` fn decrypt_in_place_detached( &self, key: &RistrettoPrivate, footer: &GenericArray<u8, Self::FooterSize>, buffer: &mut [u8], ) -> Result<(), Error> { let (footer, version_data): (_, &GenericArray<u8, U2>) = footer.split(); ``` Alternate version is like ``` fn decrypt_in_place_detached( &self, key: &RistrettoPrivate, footer: &GenericArray<u8, Self::FooterSize>, buffer: &mut [u8], ) -> Result<(), Error> { let (footer, version_data) = Split::<u8, U48>::split(footer); ``` I think these are both expected to work generic array 0.14. There are alternatives of course but they are less tidy :) Since I'm getting the generic array pub export from you, I think that to use this, I have to convince you that it's worth it to uprev. LMK what you think! Thanks
Looks like this has an MSRV bump (which is fine), but the CI config needs to be updated |
Wow, just noticed the MSRV bump is to 1.41. |
sorry I lost track of this -- I will come back to it soon let me know if you would rather hold off on MSRV bump |
I'd say let's go for it |
Thanks! Per #43 it might be a bit before this gets released. |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
May 24, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/universal-hashes
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
May 25, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 27, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/stream-ciphers
that referenced
this pull request
May 28, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/stream-ciphers
that referenced
this pull request
May 28, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
May 30, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
May 30, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
May 30, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
May 30, 2020
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
This was referenced Jun 4, 2020
Merged
Merged
Merged
Merged
Merged
Merged
G1gg1L3s
pushed a commit
to G1gg1L3s/rust-md4
that referenced
this pull request
Mar 6, 2021
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
joshuajbouw
pushed a commit
to near/near-blake2
that referenced
this pull request
Mar 15, 2021
The MSRV bump is necessary to check in a merge-friendly Cargo.lock (which is helpful for caching). We'll want to do this bump anyway soon for `generic-array` v0.14. See: <RustCrypto/traits#95>
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.14 they added a pretty nice feature, which is that you can
now split not just arrays that you hold by value, but you can
split references to generic arrays, into a pair of references to
generic arrays corresponding to the subslices, where the size
calculations are done correctly at compile-time and the buffer
size information is all preserved.
https://docs.rs/generic-array/0.14.1/src/generic_array/sequence.rs.html#302-320
I have some ECIES code that looks like this, that builds on
aead
trait:Alternate version is like
I think these are both expected to work generic array 0.14. There
are alternatives of course but they are less tidy :)
Since I'm getting the generic array pub export from you, I think
that to use this, I have to convince you that it's worth it to uprev.
LMK what you think! Thanks