Initial cmov crate
#741
Merged
Initial cmov crate
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarcieri
commented
Feb 26, 2022
tarcieri
commented
Feb 26, 2022
Implements safe wrappers for the `cmovz` and `cmovnz` instructions which work on `x86` and `x86_64`, implemented using inline assembly. Using inline assembly allows us to provide a sort of black box which LLVM will not interfere with, which is otherwise problematic when using anything besides ASM. It's otherwise not possible to correctly emit CMOV instructions on x86 platforms with LLVM because the `x86-cmov-conversion` pass which will potentially rewrite them as branches. For more details, see: https://dsprenkels.com/cmov-conversion.html
Adds a fallback implementation based on bitwise arithmetic, which allows the crate to work on any target architecture. Unfortunately, this implementation cannot guarantee constant-time operation in the same way as dedicated instructions are able to.
tarcieri
commented
Feb 26, 2022
|
Went ahead and added a portable fallback implementation for non-x86/x86_64 platforms in 5dfbdca with optimizations in 876653d which uses bitwise arithmetic but can't otherwise specifically guarantee constant-time operation. I think it's nice to have from an ergonomics perspective, even if we can't make guarantees. We could potentially add some tests that automatically inspect the generated assembly and make sure the generated instructions fall within a particular allow list. That'd provide a degree of due diligence that the resulting implementation is constant time, if not a guarantee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements safe wrappers for the
cmovzandcmovnzinstructions which work onx86andx86_64, implemented using inline assembly.Using inline assembly allows us to provide a sort of black box which LLVM will not interfere with, which is otherwise problematic when using anything besides ASM.
It's otherwise not possible to correctly emit CMOV instructions on x86 platforms with LLVM because the
x86-cmov-conversionpass which will potentially rewrite them as branches.For more details, see:
https://dsprenkels.com/cmov-conversion.html