hybrid-array: implement concat and split methods #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a particular reason to implement these in terms of traits instead of inherent methods? (other than that's what It seems like since they're impl'd for |
Convenient methods for concatenation and splitting. The size of the result is calculated in the compile time. This implementation was inspired by GenericArray implementation of Concat and Split traits.
rpiasetskyi
force-pushed
the
hybrid-array-concat-split
branch
from
026d7fa
to
ac7f14d
Compare
tarcieri
approved these changes
Oct 14, 2023
tarcieri
changed the title
rpiasetskyi
added a commit
to rpiasetskyi/utils
that referenced
this pull request
Oct 16, 2023
Convenient methods for concatenation and splitting. The size of the result is calculated in the compile time. This implementation was inspired by GenericArray implementation of Concat and Split traits. Co-authored-by: Ruslan Piasetskyi <ruslan.piasetskyi0@gmail.com>
tarcieri
pushed a commit
that referenced
this pull request
Oct 16, 2023
Convenient methods for concatenation and splitting. The size of the result is calculated in the compile time. This implementation was inspired by GenericArray implementation of Concat and Split traits. Co-authored-by: Ruslan Piasetskyi <ruslan.piasetskyi0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These traits add convenient methods for concatenation and splitting. The size of the result is calculated in the compile time.
This implementation was inspired by
GenericArrayimplementation of relevant traits.This change is necessary for RustCrypto/traits#1078