-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: Feedback on cargo-info
to prepare it for merging
#108
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
cc: @epage Would you like to review the document before it's posted on the internal forum? If you're short on time, you can also provide feedback after publication. Thanks in advance. |
I went ahead and did #109 real quick but overall, I think the question is what is your goal.
|
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Thanks! I forgot it. I've changed the title of this blog.
I want to focus on getting feedback on the unknown or uncertain designs and issues. I should emphasize the goal at the beginning or I may have too many details in this blog. What do you think? Should we put that many details in it or not? |
cargo-info
to prepare it for merging
Would Internals be a better place, than your blog? So the goal (and now title) is about feedback but the structure doesn't show that. For
|
Yes, I will post it in the Internals. I utilize this blog as a platform to review the code(content) before publishing it. |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@epage I updated it again. I deleted the scenario demos. Mentioned some background on the command. Also emphasized that I want to discuss those issues that are still undecided. Do you think this is ok for now? |
I am going to merge this PR. I will publish it on internals later and if you have anything want to add I think you can comment on the internals forum. Thanks for your review! |
rendered