Quadfit #22
Merged
Quadfit #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 31.11% 31.87% +0.75%
==========================================
Files 32 32
Lines 1324 1324
==========================================
+ Hits 412 422 +10
+ Misses 912 902 -10
Continue to review full report at Codecov.
|
eford
reviewed
Feb 15, 2022
| @testset "RV injection/extraction" begin | ||
| # velocities | ||
| amp = 1.0 # meters per second | ||
| vel = amp .* sin.(range(0, 2π, length=100)) |
There was a problem hiding this comment.
Could just test for [-\pi/2,\pi/2) and cut length in half.
eford
reviewed
Feb 15, 2022
| rvs_quad = zeros(length(vel)) | ||
| sig_quad = zeros(length(vel)) | ||
| for i in eachindex(vel) | ||
| rvs_gauss[i], sig_gauss[i] = mrv_gauss(v_grid, view(ccf, :, i)) |
There was a problem hiding this comment.
Could add test that calls version of functions that also take uncertainties in fluxes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things included in this pull request:
download_soap_example.jlso that the build step no longer fails -- EchelleCCFs fails to build due to Box download fail #21 .