Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated read_linelist_vald to new VALD 2-column mask format #4

Merged
merged 4 commits into from
Oct 29, 2020

Conversation

alexander-wise
Copy link
Collaborator

No description provided.

@alexander-wise alexander-wise requested a review from eford October 28, 2020 09:08
@eford
Copy link
Member

eford commented Oct 28, 2020

Let's pair this change with replacing the VALD mask in data/line_lists/

@alexander-wise
Copy link
Collaborator Author

updated mask file to new format

@eford
Copy link
Member

eford commented Oct 29, 2020

Changes look good, but now it's failing a test. It appears that read_mask in src/masks/masks.jl hasn't been updated to reflect the file changes.

@codecov-io
Copy link

Codecov Report

Merging #4 into main will increase coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   41.50%   41.51%           
=======================================
  Files          29       29           
  Lines         836      831    -5     
=======================================
- Hits          347      345    -2     
+ Misses        489      486    -3     
Impacted Files Coverage Δ
src/masks/io.jl 55.55% <0.00%> (+7.93%) ⬆️
src/masks/masks.jl 15.25% <100.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02e582...b148b37. Read the comment docs.

@eford eford merged commit 7c26ff9 into RvSpectML:main Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants