[WIP] Converting to Swift 3 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
💯 |
| return booleanType.boolValue | ||
| public init<B: ExpressibleByBooleanLiteral>(enabledIf: Observable<B> = Observable.just(true), workFactory: @escaping WorkFactory) { | ||
| self._enabledIf = enabledIf.map { (booleanLiteral) -> Bool in | ||
| return booleanLiteral as! Bool |
There was a problem hiding this comment.
BooleanType has been renamed to Bool.
We can make this initializer non-generic and replace the placeholder type with Bool.
|
Thanks @ishkawa. Added a few fixes for your comments. |
|
Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started the process of converting to Swift 3.
This requires
RxSwift/RxCocoato be stable, which won't happen for some weeks.I have converted the Action project and made it build using the
RxSwiftdevelop branch. When proper beta/rc are available we should update to those.As of 9th of September, the Demo project is not compiling, as the Podfile cannot use a specific branch.
I will keep updating this PR as
RxSwiftreleases new candidates.Feel free to contribute or comment.