Add support for SPM #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review @ashfurrow |
|
Thanks a lot for contributing @minuscorp! I've invited you to join the Generated by 🚫 dangerJS |
|
Tag + release? |
|
After @ashfurrow will give me access I will release it. |
|
I've seen that the after step of pushing to trunk will fail because it will find that the podspec has the same version if it's not changed before launching rocket command |
|
Tagged and released as 4.1.0 |
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new usage for release the version would be
swift run rocket {VERSION_TO_RELEASE}, i.e.swift run rocket 1.0.0This will create a tag where the test and development dependencies are hidden, I also added the typical steps for releasing the Cococapods version to trunk. Need to validate this though.