Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed dependencies support #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Managed dependencies support #67

wants to merge 1 commit into from

Conversation

kidpollo
Copy link

I came accross this porblem trying to use managed dependencies in a project that already has lein npm on it. It should be as simple as this.

RyanMcG
RyanMcG approved these changes Oct 30, 2020
View reviewed changes
Copy link
Owner

@RyanMcG RyanMcG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this change is a bit over my head, but it looks reasonable enough.

Do we need to bump the version of cemerick.pomegranate.aether to accept the :managed-coordinates param?

@kidpollo
Copy link
Author

kidpollo commented Nov 2, 2020

No, I dont even think that is adepenency in this project. Isnt it a transient dep from lein ? https://github.com/clj-commons/pomegranate/blob/master/CHANGES.md

@RyanMcG
Copy link
Owner

RyanMcG commented Nov 2, 2020

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanMcG RyanMcG RyanMcG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidpollo @RyanMcG