shows location of error in code when using cli (revised again) #73

kenirwin · 2020-04-08T16:07:47Z

Closes #70

adds errorContext() function in cli
displays the text of the line containing the error
highlights the offending character in red
adds a line below the code using a caret ^ to show where the error occurred (more accessible for some users than colored highlighting)
updates the "invalid" test to account for new expected output
supports both file-based and inline cli inputs

kenirwin · 2020-04-08T16:11:21Z

once again, this tests fine on my machine but fails on travis :(

package.json

RyanZim · 2020-04-10T13:44:00Z

Landed in 366ed9e.

RyanZim · 2020-04-10T13:53:49Z

kenirwin added 9 commits April 7, 2020 17:00

updates to package lock: acorn dependencies

cc6c4d0

added 'colors' package

2f770f1

test for colors

26f08c6

error context passes test, but has prettier errors

4a1ef0f

cleaned up prettier errors

067607a

manual red highlighting works, but not chalk

9329f17

cli works, but fails test with chalk

baec470

context passes test, doesn't look for highlighting

0d107bf

adds caret under error for better accessbility

c94b08f

kenirwin changed the title ~~Caret~~ shows location of error in code when using cli (revised again) Apr 8, 2020

RyanZim reviewed Apr 8, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

removed colors module

22d4a6c

RyanZim closed this in 366ed9e Apr 10, 2020

Provide feedback