Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom refresh rate mode to VSync option #238

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

KeatonTheBot
Copy link
Contributor

@KeatonTheBot KeatonTheBot commented Nov 13, 2024

Rebased @jcm93's refreshinterval branch: https://github.com/jcm93/Ryujinx/tree/refreshinterval

The option is placed under System/Hacks. Disabled, it's the default Ryujinx behavior. Enabled, the behavior is shown in the attached screenshots. If a framerate is too high or low, you can adjust the value where you normally toggle VSync on and off. It will also cycle through the default on/off toggles.

Also, in order to reduce clutter, I made an adjustment to remove the target FPS and only show the percentage.

image

image

@github-actions github-actions bot added gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. labels Nov 13, 2024
@KeatonTheBot KeatonTheBot force-pushed the refreshinterval branch 3 times, most recently from 19d6d4d to 4d37ee1 Compare November 15, 2024 22:28
@StevensND
Copy link

StevensND commented Nov 17, 2024

Vsync options should be renamed IMO

Switch + Unbounded tags are confusing for new users and should be replaced for something like: ON and OFF or Enabled/Disabled. New users won't know that by default Switch tag is for 30FPS and Unbounded tag is for Remove the 30FPS limit and uncap your FPS. That's something I told to you on Discord.

Sin título

After that, when changing the % IRL using the UI's slider, the text "The custom refresh rate, as a percentage of the normal Switch refresh rate" is displayed all time time so I can't know what % I'm using IRL without having to do a click on other site, check the FPS and then check the % again. I think that the text should be hide.

Sin título2

Finally, IMO a Type % + Enter option should be added so people can type 200 %, press Enter and set it instead of using the slider all the time so at the end you can use both options: the slider and the Type % + Enter option.

@KeatonTheBot
Copy link
Contributor Author

KeatonTheBot commented Nov 17, 2024

Vsync options should be renamed IMO

Switch + Unbounded tags are confusing for new users and should be replaced for something like: ON and OFF or Enabled/Disabled. New users won't know that by default Switch tag is for 30FPS and Unbounded tag is for Remove the 30FPS limit and uncap your FPS. That's something I told to you on Discord.

Yeah, you're right.

After that, when changing the % IRL using the UI's slider, the text "The custom refresh rate, as a percentage of the normal Switch refresh rate" is displayed all time time so I can't know what % I'm using IRL without having to do a click on other site, check the FPS and then check the % again. I think that the text should be hide.

Good call.

Finally, IMO a Type % + Enter option should be added so people can type 200 %, press Enter and set it instead of using the slider all the time so at the end you can use both options: the slider and the Type % + Enter option.

I was trying to save space when getting rid of the text box, but making it a percentage makes more sense.

I also need to rework how the setting is saved in the config file. It's still using the FPS amount.

@StevensND
Copy link

StevensND commented Nov 17, 2024

I was trying to save space when getting rid of the text box, but making it a percentage makes more sense.

The Type % + Enter it's more faster and more accurate IMO and maybe could be more clean (I mean type a number only, not the number + the % symbol. Ex: Type 150 and Press Enter. The UI should set and show 150 %). Sometimes you want to set 200 % and you end up setting 199% instead using the slider and the only fix it's the arrow keys.

I haven't tried it too much. I was trying to find the offset that controlled the FPS in a random game.

@gbqgbq

This comment was marked as off-topic.

@GreemDev GreemDev merged commit 2e6794e into Ryubing:master Nov 25, 2024
10 checks passed
@Ryubing Ryubing locked as resolved and limited conversation to collaborators Nov 25, 2024
@KeatonTheBot KeatonTheBot deleted the refreshinterval branch November 25, 2024 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants